Remove unreleased JSON serialization code from the CLI #1366
Conversation
Signed-off-by: Craig Disselkoen <[email protected]>
| /// Output a protobuf binary file for consumption by Lean | ||
| #[cfg(feature = "protobufs")] | ||
| #[command(subcommand)] | ||
| WriteDRTProto(serialization::AnalysisCommands), | ||
| WriteDRTProto(protobufs::AnalysisCommands), |
There was a problem hiding this comment.
Question related to existing code, but worth thinking about before releaseing protbuf code. I guess I don't really know what protofbuf functionality was added to the CLI in the first place, but how does the variant name (WriteDRTProto) relate to inner struct (AnalysisCommands)? Also, is this protobuf format still DRT specific, or should we rename this to something more general before release?
There was a problem hiding this comment.
The naming was done by #1326, I think the relationship is that AnalysisCommands is a list of the protobuf formats supported by WriteDRTProto (today, just Equivalence), all of which relate to analysis (at least today). I agree this should be changed prior to release. Let's track that in #1348; I see you've already linked this comment there
Description of changes
Following comment by @john-h-kastner-aws here.
#1326 added some JSON serialization commands to the CLI that were not guarded by the
protobufsexperimental feature. These are due to be replaced by protobuf versions. The code added by #1326 has not yet been released, so we're free to make changes before it is released without worrying about breaking things. The immediate steps taken in this PR are to:protobufsexperimental feature, and also to flatten the module while we're here.Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):
I confirm that this PR (choose one, and delete the other options):
I confirm that
cedar-spec(choose one, and delete the other options):I confirm that
docs.cedarpolicy.com(choose one, and delete the other options):